Skip to content

Conversation

@Foywards
Copy link

  1. I documented all behaviour within the code as far as I could. ANSWER: Yes, sort of?
  2. This PR targets the develop branch and not the master branch. ANSWER: Yes
  3. I have tested my changes extensively and paid extra attention to potential
    cross-platform issues (e./g. Cmd/Ctrl/Super key bindings) ANSWER: Not really, but it is a minimal change.
  4. I ran the yarn lint and yarn test commands successfully ANSWER: I ran them, they were not completely successful. See Discord discussion-dev channel for details.
  5. I have added an entry to the CHANGELOG.md ANSWER: No, as the change only affects dev environment setup
  6. I matched my code-style to the repository as far as possible ANSWER: Yes, but you don't end each statement with semi-colons? That is hard to wrap my head around. :)
  7. I agree that my code will be published under the GNUP GPL v3 license ANSWER: Yes
  8. In case I created new files, I added a header to them (see the existing
    files for examples) ANSWER: n/a
  9. Before opening this PR, I ran git pull a last time to prevent any merge
    issues ANSWER: Yes

Description

Communicate the stderr output from the get-pandoc.sh script to the forge.config.js output to let users see the error output.

Changes

There should be no breaking changes. I really only added a line or two of code to make troubleshooting errors from the get-pandoc.sh script easier for future new contributors to identify.

Additional information

It's my first PR (ever!), so I may have messed something up...

Tested on: Windows 11Home 24H2

Communicate the stderr output from the get-pandoc.sh script to the forge.config.js output to let users see the error output.
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 26, 2025

Thank you for opening your first PR! 🎉 We would like to thank you already for your contribution. If everything checks out, we'll make sure to review the PR as soon as possible and give feedback. Please note a few things:

  • For every PR, the automated pipeline will run the linter and unit tests on
    your code. Should these fail, we will not merge your PR.
  • Activate your notifications and check your inbox regularly to respond to our
    reviews and/or comments.

We are glad for every improvement that makes its way into the app, so we look forward to collaborating on merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant