Skip to content

Fix line length violations in tpaptransport.py debug logging#2

Merged
ZeliardM merged 4 commits intofeature/tpapfrom
copilot/check-ci-workflows
Dec 14, 2025
Merged

Fix line length violations in tpaptransport.py debug logging#2
ZeliardM merged 4 commits intofeature/tpapfrom
copilot/check-ci-workflows

Conversation

Copy link

Copilot AI commented Dec 14, 2025

Pre-commit checks were failing due to E501 line length violations (>88 chars) in TPAP debug logging statements added in previous commits.

Changes

  • kasa/transports/tpaptransport.py: Split 9 long debug/warning log statements across multiple lines to comply with ruff's 88-character limit
  • .gitignore: Added coverage.xml to prevent committing test artifacts

Example

# Before
_LOGGER.warning("SPAKE2+: Failed to compute password_sha_with_salt: %s, falling back to passcode", exc)

# After
_LOGGER.warning(
    "SPAKE2+: Failed to compute password_sha_with_salt: %s, "
    "falling back to passcode",
    exc,
)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • astral.sh
    • Triggering command: /usr/bin/curl curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

I need you to check with the latest commits. For this python api, they use uv sync --all-extras to setup a .venv then run uv run precommit run -a to test for their internal sets, then uv run pytest for code on coverage tests as well. It's all in the CI workflows and we need to make sure that the current commit on the feature/tpap branch works with all this. Make any changes that need to be made, push new commits to get the precommit and tests working.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits December 14, 2025 00:12
Co-authored-by: ZeliardM <140266236+ZeliardM@users.noreply.github.com>
Co-authored-by: ZeliardM <140266236+ZeliardM@users.noreply.github.com>
Co-authored-by: ZeliardM <140266236+ZeliardM@users.noreply.github.com>
Copilot AI changed the title [WIP] Ensure CI workflows pass with latest commits Fix line length violations in tpaptransport.py debug logging Dec 14, 2025
Copilot AI requested a review from ZeliardM December 14, 2025 00:20
Copy link
Owner

@ZeliardM ZeliardM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ZeliardM ZeliardM marked this pull request as ready for review December 14, 2025 00:49
Copilot AI review requested due to automatic review settings December 14, 2025 00:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses pre-commit check failures by fixing E501 line length violations in the TPAP transport module's debug logging statements and adds a missing coverage file to .gitignore.

  • Split 9 long debug/warning log statements in tpaptransport.py across multiple lines to comply with ruff's 88-character limit
  • Added coverage.xml to .gitignore to prevent committing test artifacts

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
kasa/transports/tpaptransport.py Reformatted 9 debug/warning log statements to comply with 88-character line length limit by splitting them across multiple lines
.gitignore Added coverage.xml to exclude pytest coverage reports from version control

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ZeliardM ZeliardM merged commit 547ead9 into feature/tpap Dec 14, 2025
6 checks passed
@ZeliardM ZeliardM deleted the copilot/check-ci-workflows branch December 14, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants