Allow multiple FAQ blocks and fix FAQ and How To markup#21402
Merged
enricobattocchi merged 2 commits intorelease/22.8from May 23, 2024
Merged
Allow multiple FAQ blocks and fix FAQ and How To markup#21402enricobattocchi merged 2 commits intorelease/22.8from
enricobattocchi merged 2 commits intorelease/22.8from
Conversation
1914e7b to
237f6bf
Compare
Pull Request Test Coverage Report for Build 39be37fc0bdbedb5afc04e0672a06a1815dd0166Details
💛 - Coveralls |
573feee to
552c540
Compare
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
1. Multiple FAQ blocks
New blocks
FAQPagewithmainEntityset to all theQuestionpieces from all the FAQ blocks combinedUpgrading
* if you now upgrade to 22.7 and edit the post you'll see a warning telling you that you cannot use the block twice.
2. Block markup
New blocks
<div class="schema-faq wp-block-yoast-faq-block">and the How-to block as<div class="schema-how-to wp-block-yoast-how-to-block">Upgrading from 22.6 or earlier
<div class="schema-faq wp-block-yoast-faq-block">and the How-to block as<div class="schema-how-to wp-block-yoast-how-to-block">Upgrading from 22.6 or earlier
<div class="schema-faq wp-block-yoast-faq-block">and the How-to block as<div class="schema-how-to wp-block-yoast-how-to-block">Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #21401
Fixes #21403