Fix double-slash in category URL rewrite and missing trailing slash in BuildUrl#1634
Open
mt0321 wants to merge 1 commit intoYAFNET:masterfrom
Open
Fix double-slash in category URL rewrite and missing trailing slash in BuildUrl#1634mt0321 wants to merge 1 commit intoYAFNET:masterfrom
mt0321 wants to merge 1 commit intoYAFNET:masterfrom
Conversation
…n BuildUrl AddCategoryRules produced a double slash (e.g. forums//index/) because areaSegment ended with '/' and GetPageName() returns a leading '/'. Use CombineWith to safely join path segments. BuildUrl silently dropped the trailing slash because AppendTrailingSlash() was called without assigning its return value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddCategoryRules produced a double slash (e.g. forums//index/) because areaSegment ended with '/' and GetPageName() returns a leading '/'. Use CombineWith to safely join path segments.
BuildUrl silently dropped the trailing slash because AppendTrailingSlash() was called without assigning its return value.