Added option to only generate HTML/JUnit for failed tests via -f#236
Open
amleszk wants to merge 1 commit intoXCTestHTMLReport:mainfrom
Open
Added option to only generate HTML/JUnit for failed tests via -f#236amleszk wants to merge 1 commit intoXCTestHTMLReport:mainfrom
amleszk wants to merge 1 commit intoXCTestHTMLReport:mainfrom
Conversation
amleszk
force-pushed
the
al_failures_reported_only
branch
from
2aa6a1d to
61b0c73
Compare
tylervick
approved these changes
Nov 5, 2021
Member
tylervick
left a comment
tylervick
left a comment
There was a problem hiding this comment.
nice addition!
@amleszk Are you able to share any additional details on the time complexity you're seeing?
I'm wondering if there's anything we can do to reduce extraneous calls made to xcrun, particularly around reusing extracted data from actions, etc.
|
+1 for this |
Contributor
Author
|
Thanks @tylervick i think the only fix would be to stop depending on |
Contributor
Author
|
I still cannot merge this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At Grubhub there are CI builds where we run the
XCHTMLReportagainst 14000 unit tests, which takes a long time because the app makes repeated calls to the terminal app invoked by external library.package(url: "https://github.com/davidahouse/XCResultKit.git", .upToNextMinor(from: "0.9.2")),.Exact source: https://github.com/davidahouse/XCResultKit/blob/main/Sources/XCResultKit/XCResultFile.swift#L136
And the build time for this report takes 30 minutes, which is way too long.
This PR makes a high level change to introduce a new parameter
-fwhich will ignore reporting on tests that have passed. Only reporting on failures. This reduces the report build time to about 1 minute, and still allows for the report to contain the information that is relevant to a CI build failure.Changes
RenderingArguments-fisEmptyto andcompactMapTest models to filter those that are empty of any tests. removing noise from the test reportif status == .success && renderingArgs.failingTestsOnly {