Document how the upcoming version output can be used to allow commands to fail without failing the build #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because you asked in #9 (comment) 😅 Took me a couple minutes to figure out how this works, was confusing by "why does this match a file With the - name: Execute tests
if: needs.supported-versions-matrix.outputs.upcoming == matrix.php && always()
run: composer testBut no idea if always() works that way |
Owner
Author
|
Been trying to do https://github.com/WyriHaximus/php-test-utilities/pull/652/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR109-L142 instead. But no luck so far :(. |
WyriHaximus
force-pushed
the
document-not-failing-for-upcoming-versions
branch
from
5d5d8d7 to
e5a27d7
Compare
to fail without failing the build This is a really crude but effective away of doing it. Especially if your command also sets per line annotations on PR's you still get the feedback you'd want from your commands without breaking the build.
WyriHaximus
force-pushed
the
document-not-failing-for-upcoming-versions
branch
from
e5a27d7 to
56d8f52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really crude but effective away of doing it. Especially if
your command also sets per line annotations on PR's you still get the
feedback you'd want from your commands without breaking the build.