This repository was archived by the owner on Mar 9, 2023. It is now read-only.
Fix connection cost lookup, fix #129#131
Merged
sorami merged 2 commits intoWorksApplications:developfrom Jun 18, 2020
Merged
Conversation
The connection costs lookup was backwards. There was a comment in the pre-cython code that the call to the cost lookup function looked backwards, but was actually correct. It was calling with (l_node.right_id, r_node.left_id). I kept this order when I replaced the function call with a memoryview access, but that was wrong; I hadn't noticed that the access function was actually reversing the order of its arguments. This fix was verified by checking the tokenization of a short document vs v0.4.5 and making sure there were no changes.
Collaborator
|
@polm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connection costs lookup was backwards.
There was a comment in the pre-cython code that the call to the cost
lookup function looked backwards, but was actually correct. It was
calling with (l_node.right_id, r_node.left_id). I kept this order when I
replaced the function call with a memoryview access, but that was wrong;
I hadn't noticed that the access function was actually reversing the
order of its arguments.
This fix was verified by checking the tokenization of a short document
vs v0.4.5 and making sure there were no changes.