Support logging errors as warnings #67
Conversation
Dimitris-Ilias
requested review from
DimitrisKalogeropoulos,
Michalis-Apostolou,
dktistakis and
manoskouvarakis
Dimitris-Ilias
changed the title
ts/base-queue-handler.ts
Outdated
| handleError(err, msg) { | ||
| this.logger.error(err); | ||
| const logLevel = err?.logLevel || 'error'; | ||
| this.logger[logLevel](err); |
There was a problem hiding this comment.
I don't like that passing something "erroneous" (even a typo) will result to break the whole handling in base handler of a public library.
A validation would suffice or a parameter to switch between error/warning
There was a problem hiding this comment.
@manoskouvarakis Went with the parameter to switch between error/warning approach.
I used name shouldLogWarning but I'm open to suggestions...
Cytal? cc @DimitrisKalogeropoulos @dktistakis
There was a problem hiding this comment.
What about logAsWarning ?
There was a problem hiding this comment.
Looks good. Either name would be fine.
There was a problem hiding this comment.
I think logAsWarning best describes what we want to achieve, other than that it's great 👏
There was a problem hiding this comment.
@manoskouvarakis @dktistakis @DimitrisKalogeropoulos
I like logAsWarning better too. Done
Also added tests for the new(and the old) functionality
Dimitris-Ilias
dismissed stale reviews from dktistakis and DimitrisKalogeropoulos
via
8a38f15
Dimitris-Ilias
force-pushed
the
support_custom_log_level_when_logging_errors
branch
from
acec39a to
8a38f15
Compare
| ports: | ||
| - '5672:5672' |
There was a problem hiding this comment.
This was needed in order for tests to "play" locally
Dimitris-Ilias
deleted the
support_custom_log_level_when_logging_errors
branch
Dimitris-Ilias
changed the title
https://workable.atlassian.net/browse/PROD-67888
rabbit-queueautomatically logs errors using anerrorlogLevel,but this isn't always desirable by the users of the module
This PR adds basic support for the raiser of the error to be able to specify a boolean
logAsWarningattribute for that error, which will makerabbit-queuelog a warning instead of an error