SEO: Change separator to pipe. #384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
approved these changes
Jan 23, 2024
Contributor
ryelle
left a comment
ryelle
left a comment
There was a problem hiding this comment.
Looks good.
If this is the expected format, maybe it's something we should move to site-branding.php mu-plugin?
Co-authored-by: Kelly Dwan <ryelle@users.noreply.github.com>
Contributor
Author
Yeah, that's a good call. I move this change over there and close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of our subsites use a "|" as a separator. This PR updates the main theme to use the "|" separator as well.
This has come up as a result of working on #375.
Example
Currently, the main theme doesn't enforce that pattern and we get the default "-" separator.