Repository navigation
Create pattern for hosting page - #203
bengreeley wants to merge 6 commits into
Conversation
|
Regarding the PHP lint error, if you use the content exporter to create a pattern from the prod page the PHP should pass lint. See https://github.com/WordPress/wporg-main-2022#building-patterns-from-page-content You'll need to add the I wasn't aware of this workflow either when I started Enterprise, so we probably need to make it more prominent |
adamwoodnz
added
the
[Component] Content
|
Thanks for pointing out that generator @adamwoodnz . Now that I know it's there it shouldn't be an issue, I probably should have asked beforehand. |
|
No worries :) One more tip; I find it more efficient to delete all the other entries from the manifest, so that only the page I'm working on gets run |
| <!-- wp:group {"style":{"spacing":{"padding":{"right":"var:preset|spacing|30","left":"var:preset|spacing|30","top":"var:preset|spacing|60"},"blockGap":"0px","margin":{"top":"0"}}},"layout":{"type":"constrained"}} --> | ||
| <div class="wp-block-group" style="margin-top:0;padding-top:var(--wp--preset--spacing--60);padding-right:var(--wp--preset--spacing--30);padding-left:var(--wp--preset--spacing--30)"><!-- wp:paragraph {"style":{"spacing":{"margin":{"bottom":"var:preset|spacing|30"}}}} --> |
There was a problem hiding this comment.
All these blocks that go to the edge of the page should use the Edge Spacing preset on left and right. This gives 80px padding on large screens and clamps to 20px on small.
Creates a new pattern for the hosting page, which will be used at https://wordpress.org/hosting.
To test, create a new page with the slug hosting-2, verify that when viewing the page the new hosting page content loads. (see screenshot).
Note that this PR is temporarily making changes to https://wordpress.org/hosting-2/ until launch. Launching will be replacing the instance of
hosting-2withhostingin theme-switcher.php