Theme: Fix all lint errors and warnings - #83

Stacked on #82, which adds the lint tooling and configs. Merge that first; this PR's base will then switch to trunk.

After this, npm run lint:js, lint:css and lint:php all pass with 0 errors and 0 warnings. Ignoring whitespace, the diff is +202/−810; most of the rest is re-indentation from wrapping scripts in IIFEs and removing a dead if ( false ) branch. Review with "Hide whitespace".

JS

• Every script is now wrapped in an arrow IIFE and uses const. Swapping var for const directly isn't safe: these are classic scripts sharing one global scope, and several declare the same names (el in three files, __, …). Top-level const would throw a redeclaration SyntaxError and stop the script.
• The demo blocks' edit functions are now named Edit components, so useBlockProps() satisfies react-hooks/rules-of-hooks.
• editor-modifications.js uses window.FileReader. A file-wide /* eslint-disable no-undef */ had been hiding that FileReader wasn't a known global.
• The Openverse picker's JSDoc types are complete (no more Function types), plus Prettier formatting.

CSS

• The duplicate .interface-interface-skeleton rule is merged into one.
• Removed the @media (max-width: 782px) rule. Its inline // comment made the selector invalid, so it never applied. The .admin-bar rule after it already covers that breakpoint, because Blockbase sets --wpadmin-bar--height to 46px on mobile.
• The long outline-button selectors are broken at a descendant combinator. Same selector, same specificity.

PHP

• Dead code removed:
  • The if ( false ) static-mobile branch, which was disabled in ece1110. Its only assets, gutenberg-content-mobile.php and style-mobile.css, are deleted too, along with the now-unused $hook parameter.
  • The editor-styles loop. get_block_editor_settings() overwrites styles with core's own (array_merge( $global_styles, get_block_editor_theme_styles() )), so it never had an effect. It also used file_get_contents().
  • frontenberg_site_title(), orphaned since its filters were removed in 3ff0c32.
  • The $GLOBALS['wp_rich_edit'] write. The user_can_richedit filter right after it already forces true.
• Enqueues: script versions use filemtime(), and $in_footer is now explicit. They stay in the header, which preserves the current load order. postbox keeps its theme registration with core's version, plus a comment on why it's needed: core only registers postbox in wp-admin, and wp-edit-post depends on it. I found that out by removing it.
• 'gutenberg' text domain strings are now 'wporg', plus wp_json_encode(), wp_parse_url(), a Yoda condition, file and function doc comments, and phpcbf formatting.

Testing

Chrome, local wp-env on WP 7.2-beta1, logged out, fresh localStorage:

• No PHP notices and no console errors or notices. All 188 blocks load, with the expected title.
• The demo button and link blocks register and render. The outline button keeps its transparent background and 1px border.
• The W button, welcome guide off, fullscreen on, sidebar closed on load, publish sidebar disabled, saving locked.
• core/shortcode unregistered, "Submit for Review" shows as "Publish", the URL stays on /, and no unload warning after edits.
• Uploads work through the fake media endpoint, the Openverse picker opens, and there are no users/me requests.
• Rich editing is on, the editor gets core's theme styles (8), postbox loads, and the editor layout offsets are 0 with fullscreen on and off.

🤖 Generated with Claude Code