Repository navigation
Update the phpcs toolchain and fix the lint run - #3
Merged
Merged
Conversation
wporg-repo-tools now requires phpcodesniffer-composer-installer ^1.0 and PHPCompatibility 3.0 alpha, so the pinned ^0.7.0 and the lockfile's stale wporg-mu-plugins commit left `composer install` and the fallback `composer update wporg/*` both failing in CI. - Allow alpha stability with prefer-stable, as wporg-main-2022 does - Bump the installer plugin to ^1.0 and composer/installers to ^2.0 - Refresh the lockfile: phpcs 3.13.6, PHPCompatibility 10 alpha 2, current repo-tools and mu-plugins builds - Ignore eslint.config.js, which update-configs now generates Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
phpcbf handled the alignment, elseif and embedded PHP formatting. The editor script now sets $in_footer explicitly, and the table of contents query ignores the slow meta query sniff, since the book only has a few dozen chapters. Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
The mu-plugins build branch is force-pushed on every merge, so the locked commit disappears within days and `composer install` fails. The fallback then updated every wporg/* package, which also pulled a newer repo-tools ruleset into the lint run. Limit the fallback to mu-plugins, which the lint does not use, so the standard only changes when the lockfile does. Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
Its setup action asks projects to drop their own pins on wpcs, php_codesniffer, PHPCompatibility and the installer plugin, so the versions only move when repo-tools does. Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lint workflow has failed on every run since July, so #2 could not be checked by CI.
composer installfails because the lockfile pins a wporg-mu-plugins build commit that no longer exists, and the fallbackcomposer update wporg/*fails because wporg-repo-tools now requiresdealerdirect/phpcodesniffer-composer-installer ^1.0and PHPCompatibility 3.0 alpha, which conflict with the^0.7.0and*constraints here.Changes
prefer-stable, matching wporg-main-2022 and repo-tools itself.composer/installersto^2.0, which removes a PHP 8.4 deprecation notice on every Composer run.composer update wporg/wporg-mu-plugins. The mu-plugins build branch is force-pushed on every merge, so its locked commit disappears within days. The oldwporg/*fallback also pulled a newer repo-tools ruleset into the lint run each time that happened, which is how 45 violations appeared in files that passed in July. The lint does not use mu-plugins, so the standard now only changes when the lockfile does.eslint.config.js, whichupdate-configsnow writes.wporgstandard reports in the theme. 42 were phpcbf formatting fixes (alignment,elseif, embedded PHP tags on their own lines). The editor script sets$in_footerexplicitly, and the table of contents query ignores the slow meta query sniff, since the book only has a few dozen chapters.Testing
composer install,composer exec update-configs,npm run lint:phpandnpm run lint:cssall pass locally on PHP 8.4.🤖 Generated with Claude Code