Repository navigation
Fix PHP 5.2-5.4 containers - #44
Merged
Merged
Conversation
… containers not running.
pento
approved these changes
Oct 19, 2020
pento
left a comment
pento
left a comment
Member
There was a problem hiding this comment.
👍🏻 Noice.
The 5.2 and 5.3 versions of the CLI container could probably just be eliminated
This would likely make it harder to back-port the Docker config to older WP branches, since it would need to switch whether or not a CLI container can be created, depending on the PHP version.
or updated to use 5.4 so that the CLI is accessible.
This is the a potential option. The only real downside is that CLI will be using a different PHP version, which could cause surprising behaviour if you're not aware of it. Perhaps echoing a warning on the CLI Dockerfile would help with that?
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing xDebug and opcache seems to at least keep the containers running.
WP CLI won't run on 5.2/5.3 (not supported). But manually installing WordPress through the browser works fine. I did some quick testing and it looks like using the 5.4 CLI image with those versions of PHP works fine. The 5.2 and 5.3 versions of the CLI container could probably just be eliminated, or updated to use 5.4 so that the CLI is accessible.
Fixes #43.