PHPCompat: remove PHP4-style constructor

jrfnl · jrfnl · commit 805c0107f8ea · 2022-10-21T03:12:17.000+02:00
PHP 4-style constructors where the constructor function name mirrors the class name have been deprecated since PHP 7.0 and support has been removed since PHP 8.0, which means they are now silently ignored. Considering the constructor is empty and is overloading an equally [empty constructor in the `WP_Importer` class](https://developer.wordpress.org/reference/classes/wp_importer/), I'm fixing this by removing the method. This should not be considered a BC-break as calling the constructor directly on an instantiated object was never the intention of the code anyway and instantiating the object via `new WP_Categories_to_Tags()` will now fall through to the parent constructor, which equally does nothing anyway. Refs: * https://wiki.php.net/rfc/remove_php4_constructors
diff --git a/wpcat2tag-importer.php b/wpcat2tag-importer.php
@@ -475,8 +475,6 @@ function init() {
 
 		$this->footer();
 	}
-
-	function WP_Categories_to_Tags() { /* Do nothing. */ }
 }
 
 $wp_cat2tag_importer = new WP_Categories_to_Tags();

Original file line number	Diff line number	Diff line change
`@@ -475,8 +475,6 @@ function init() {`
`475`	`475`
`476`	`476`	`$this->footer();`
`477`	`477`	`}`
`478`		`-`
`479`		`- function WP_Categories_to_Tags() { /* Do nothing. */ }`
`480`	`478`	`}`
`481`	`479`
`482`	`480`	`$wp_cat2tag_importer = new WP_Categories_to_Tags();`