Repository navigation
REST: Add missing text domain and fix typos in REST API controller strings - #644
Open
devmuhib009 wants to merge 1 commit into
Open
devmuhib009 wants to merge 1 commit into
devmuhib009 wants to merge 1 commit into
Conversation
masteradhoc
approved these changes
Oct 23, 2026
masteradhoc
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @devmuhib009! While this looks good i saw there are several other locations in the code that dont yet have a text domain attached. Might be worth checking in a separate PR in case you have some time?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds the missing
'wp-feature-notifications'text domain argument to all__( ... )translation calls in the REST API controllers and fixes grammatical typos and punctuation in user-facing error messages and schema descriptions.Why?
Fixes #643.
In
includes/restapi/:__( '...' )translation calls omitted the plugin's text domain argument. Without the text domain, WordPress translation systems cannot accurately extract or localize these strings.class-channel-controller.php: "Sorry, you must be logged to view channels." (missing "in"); "The default view context the notification channel." (missing "of").class-notification-controller.php: "Sorry, you must be logged check notifications." (missing "in to"); "The URL of the accept action.." (extra period); "The view context the notification." (missing "of"); "The identifier of user the notification is belongs to." (grammatical error).class-subscription-controller.php: "The identifier of user the subscription is belongs to." (grammatical error).How?
'wp-feature-notifications'as the second argument to all__( ... )calls across:includes/restapi/class-channel-controller.phpincludes/restapi/class-notification-controller.phpincludes/restapi/class-subscription-controller.phpTesting Instructions
composer lintto verify that all files conform to WordPress Coding Standards.Screenshots or screencast
Not applicable (REST schema/controller strings only).
Cc @Sephsekla @erikyo @johnhooks for review.