Repository navigation
Conversation
|
Tested this against current
The red checks here look like a CI infra problem from December, not this change. The jobs exited with code 127 before any step ran. The logs have expired, so I can't confirm more than that. A rebase should re-run CI. One small note: these methods are not final, so a class outside the plugin that extends them and overrides Could you rebase and add "Fixes #634" to the description so the issue closes on merge? |
masteradhoc
left a comment
There was a problem hiding this comment.
Thank you @SirLouen for the PR! This looks good to me. I've added "Fixes" to the PR description and rebased it. Good to get merged @jonathanbossenger
What?
There are plenty of deprecation errors to be solved.
Fixes #634
Why?
jsonSerializereturn types are missing