Trac JS Overwork by timse201 · Pull Request #977 · WordPress/wordpress.org

timse201 · 2026-10-01T04:30:05Z

Many bug fixes. Full rewrite in Vanilla JS and backwards compatible with jQuery. Some jQuery checks might be useless.

Improvements:

Add accessibility attributes and focus management to the keyword workflow.

Performance:

Pre-compile mentionsRegEx and gutenbergIssueRegEx once at module scope to avoid re-compilation on every run.
Use startsWith() instead of dynamic RegExp in autocomplete filters for faster substring matching.
Batch DOM insertions using DocumentFragment in linkTextNodes() and keyword workflow methods to reduce reflows.
Combine multiple replacement passes in capital_P_dangit() into a single regular expression.
Streamline escapeHtml() using direct string entity replacements instead of temporary DOM node creation.

Error handling & network:

Add HTTP response checks (res.ok) to fetch() calls in reports and GitHub PR modules.
Provide clear user-facing error messages on failed GitHub PR fetches, and enable a retry button on report failure.
Ensure loading spinners on star indicators are cleared in a finally block on network completion or failure.

Bug fixes:

Autocomplete: Prevent syntax crashes when typing special regex characters.
Ticket ID: Reliably extract ticket numbers from canonical URLs containing query strings or hash fragments.
Unsaved changes: Detect modified summary and description fields on existing tickets, and prevent some unnecessary warnings.
Handbook: Correct the Security FAQ URL.
Selectors: Use CSS.escape() for keyword selector queries.

Assisted by Gemini 4 and 3.8 Flash

Summary by CodeRabbit

Bug Fixes
- Made unsaved-change warnings more accurate for ticket summaries, descriptions, and comments.
- Improved GitHub pull request loading, including clearer error and retry states.
- Improved ticket and report star counts and subscription status, as well as workflow controls and component suggestions.
Updates
- Updated attachment previews to include image links and video playback controls.
- Adjusted text escaping and mention matching.

coderabbitai · 2026-10-01T04:30:24Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Last reviewed commit: 5549d2c

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
No files to review - (🔄 Check again to try again)

📝 Walkthrough

The Trac JavaScript updates ticket text handling, form interactions, participant and workflow controls, notifications, and GitHub pull-request reporting. It replaces many jQuery operations with native DOM APIs and updates shared utilities.

Changes: Trac Interface and Workflow Updates

Layer / File(s)	Summary
Text processing and shared utilities `wordpress.org/public_html/style/trac/wp-trac.js`	Shared initialization, current-user access, escaping, mention matching, link generation, and attachment previews use updated utility and DOM handling.
Ticket forms and page interactions `wordpress.org/public_html/style/trac/wp-trac.js`	Ticket editing, form notices, validation, navigation, toolbar actions, tracker selection, and report-popup loading use native DOM APIs and updated guards.
Participants and workflow controls `wordpress.org/public_html/style/trac/wp-trac.js`	Participant filtering, keyword editing, and contributor-focus controls use native DOM traversal and listeners. Keyword state uses arrays, and keyword additions reject empty or duplicate values.
Notifications and report subscriptions `wordpress.org/public_html/style/trac/wp-trac.js`	Notification and report subscription controls use native events and `fetch`. Request failures and local subscription state updates are handled in the interface.
GitHub reporting and component suggestions `wordpress.org/public_html/style/trac/wp-trac.js`	GitHub pull-request loading uses `fetch` with failure and retry handling. Component suggestions and review labels use native DOM operations and guarded element access.

Priority: ⬇️ Low

Estimated code review effort: 4 (Complex) | ~50 minutes

Change: Refactor

Suggested reviewers: obenland

Merge Risk: 🔵 Low · up to 965b3

Copying a long ticket draft can disable the warning before leaving the original page. Fix that narrow draft-loss risk before merging, or accept it explicitly.

### Architecture Summary

Architecture risk: 🟡 Medium · up to f2b03

The change affects 1 system.

Changed systems: wordpress.org

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — wordpress.org (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in wordpress.org/public_html/style/trac/wp-trac.js: Removed the wpTracCurrentUser globals declaration.
observed — Modified behavior in wordpress.org/public_html/style/trac/wp-trac.js: escapeHtml now converts non-string values to strings, treating nullish values as empty, then escapes ampersands, angle brackets, quotes, and apostrophes.
observed — Modified behavior in wordpress.org/public_html/style/trac/wp-trac.js: linkTextNodes now returns for non-global or non-RegExp inputs and uses the tree walker filter to reject text inside links and skip blank text nodes; the old post-walk link check is removed.
observed — Modified behavior in wordpress.org/public_html/style/trac/wp-trac.js: wpTrac.currentUser now reads window.wpTracCurrentUser and defaults to null, rather than directly using the undeclared global.

Reliability and maintainability

inferred — Risk-relevant change factors for wordpress.org: blast_radius_1; direct_dependents_1

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 24.39% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 41 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title identifies the main change: substantial rework of the Trac JavaScript implementation. It is concise and related to the full rewrite and bug fixes.

Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

sirreal and others added 22 commits August 28, 2025 11:32

Trac: Add information link to workflow keywords

71df3fb

Merge branch 'trunk' into 8027/trac-add-link-to-workflow-documentation

207b3c0

Update wp-trac.js

04969c3

Update wp-trac.js

f4627bc

area label + target blank

db648d2

Merge branch 'trunk' into 8027/trac-add-link-to-workflow-documentation

74765de

some fixes

dafaeee

Update wp-trac.js

cb512cd

fix URLs

015f1e5

Update wp-trac.js

4732c21

Modernization + restore move away message

058e502

Update wp-trac.js

af2c228

Update wp-trac.js

e5d6a8d

Update wp-trac.js

f6b7a8e

Update wp-trac.js

6a28a18

add ajax fails

a23e6fa

Update wp-trac.js

b4b9620

Update wp-trac.js

b6828c2

Update wp-trac.js

6863aa4

Update wp-trac.js

659e31e

Update wp-trac.js

69b9d73

Update wp-trac.js

a247e02

timse201 added 4 commits October 1, 2026 06:32

Update wp-trac.js

82eb1a8

Update wp-trac.js

5e53d8b

Update wp-trac.js

52ff4b6

Update wp-trac.js

da72c6b

timse201 added this to WordPress.org Oct 1, 2026

Update wp-trac.js

fb2e29c

This comment was marked as outdated.

Sign in to view

timse201 added 26 commits October 16, 2026 19:47

Update wp-trac.js

35bba75

Update wp-trac.js

4acda68

Update wp-trac.js

cc106b6

Update wp-trac.js

190349a

Update wp-trac.js

40f8fef

Update wp-trac.js

5bef0dc

Update wp-trac.js

2b1b92b

Update wp-trac.js

465f4cd

Update wp-trac.js

ac1d547

Update wp-trac.js

5531d58

Update wp-trac.js

9e453bd

Update wp-trac.js

a036a01

Update wp-trac.js

4cda628

Update wp-trac.js

b3bcf58

Update wp-trac.js

d910405

Update wp-trac.js

2bc9882

Update wp-trac.js

d55881a

Update wp-trac.js

2f75b42

Update wp-trac.js

7a1ba02

Update wp-trac.js

b81d3db

Update wp-trac.js

af4db80

Update wp-trac.js

5c156ff

Update wp-trac.js

ba513bd

Update wp-trac.js

40e0b5e

Update wp-trac.js

84b0819

Update wp-trac.js

5549d2c

timse201 closed this Oct 24, 2026

github-project-automation Bot moved this from 🏗 In progress to ✅ Done in WordPress.org Oct 24, 2026

timse201 removed this from WordPress.org Oct 24, 2026

timse201 removed the [Site] Trac label Oct 24, 2026

Navigation Menu

Repository navigation

Trac JS Overwork - #977

Trac JS Overwork#977
timse201 wants to merge 112 commits into
WordPress:trunkfrom
timse201:8027/trac-add-link-to-workflow-documentation-1

timse201 commented Oct 1, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 1, 2026 •

edited

Loading

Reviews paused

Uh oh!

This comment was marked as outdated.

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

timse201 commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Uh oh!

This comment was marked as outdated.

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

timse201 commented Oct 1, 2026 •

edited

Loading

coderabbitai Bot commented Oct 1, 2026 •

edited

Loading