Skip to content

Jobs: Document the post-a-job form render path - #910

Closed
KokkieH wants to merge 1 commit into
WordPress:trunkfrom
KokkieH:jobswp-form-render-path
Closed

KokkieH wants to merge 1 commit into
WordPress:trunkfrom
KokkieH:jobswp-form-render-path

Conversation

@KokkieH

@KokkieH KokkieH commented Sep 11, 2026

Copy link
Copy Markdown

The post-a-job form is added to the_content, but get_template_part() echoes its template and returns null, so the $content .= get_template_part( ... ) calls append nothing — the form goes straight to the output stream. That is easy to misread as a bug and "tidy" into an output-buffered append, which would change what the rest of the filter chain sees.

  • Documents the render path in the docblock, and corrects the @return description.
  • Runs the filter at priority 12 rather than 10, so the form is emitted above core do_shortcode() at 11 and submitted values are never re-parsed as markup.

No behavioural change is expected: the form already renders outside the parser. Worth an eyeball on a sandbox though, since the priority bump shifts the form relative to other priority 10/11 the_content filters — both the empty-form render of /post-a-job/ and the error/verify re-render.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 50aa214b-5658-438d-908f-7018d530f254

📥 Commits

Reviewing files that changed from the base of the PR and between ab56ca4 and eb42874.

📒 Files selected for processing (1)
  • jobs.wordpress.net/public_html/wp-content/plugins/jobswp/jobswp.php

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KokkieH
KokkieH marked this pull request as ready for review September 11, 2026 13:29
@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props kokkieh, bor0.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

- Note that get_template_part() echoes, so the appends are no-ops
- Run the filter at priority 12 to keep the form out of the shortcode parser

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@KokkieH
KokkieH force-pushed the jobswp-form-render-path branch from d26c31b to eb42874 Compare September 11, 2026 13:35
@KokkieH
KokkieH requested a review from bor0 September 11, 2026 13:36
wporg-sync pushed a commit that referenced this pull request Sep 11, 2026
git-svn-id: https://meta.svn.wordpress.org/sites/trunk@15185 74240141-8908-4e6f-9713-ba540dce6ec7
@bor0

bor0 commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

Fix is live, committed to svn

Sending        jobswp.php
Transmitting file data .done
Committing transaction...
Committed revision 15185.
[jobswor@morse jobswp]$ 

8471c13

@bor0 bor0 closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants