Repository navigation
Bump the minimum recommended version of PHP to 8.3 - #497
Closed
johnbillion wants to merge 2 commits into
Closed
johnbillion wants to merge 2 commits into
johnbillion wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum recommended and supported PHP version constants for ServeHappy to align with current PHP support policies.
- Bumps
RECOMMENDED_PHPfrom 7.4 to 8.3 - Bumps
SUPPORTED_PHPfrom 7.4 to 8.3 - Bumps
SECURE_PHPandACCEPTABLE_PHPfrom 7.4 to 8.1
Comments suppressed due to low confidence (2)
wordpress.org/public_html/wp-content/mu-plugins/pub/servehappy-config.php:13
- Consider adding or updating unit/integration tests to verify that the updated PHP version constants correctly trigger the ServeHappy dashboard behavior.
define( 'RECOMMENDED_PHP', '8.3' );
wordpress.org/public_html/wp-content/mu-plugins/pub/servehappy-config.php:10
- [nitpick] Include a @link to the official PHP supported versions page in the file header to help future maintainers track where these numbers come from.
*/
johnbillion
marked this pull request as ready for review
July 7, 2025 10:50
desrosj
reviewed
Jul 8, 2025
|
|
||
| // The lowest branch of PHP which is receiving security updates. | ||
| define( 'SECURE_PHP', '7.4' ); | ||
| define( 'SECURE_PHP', '8.1' ); |
Member
There was a problem hiding this comment.
Just noting that this will need to be bumped again in January to 8.2.
desrosj
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumpity bump.
SUPPORTED_PHPgets bumped to 8.3 because that's the oldest version actively supported by the PHP projectSECURE_PHPandACCEPTABLE_PHPget bumped to 8.1 because that's the oldest version receiving security updates from the PHP projectRECOMMENDED_PHPgets bumped to 8.3 because that's the highest version that's fully supported by the latest version of WordPressDepends on
Refs
Core PR