Skip to content

Photo Directory: Round shutter speeds and show long exposures in seconds #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ekamran wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Photo Directory: Round shutter speeds and show long exposures in seconds #1101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion wordpress.org/public_html/wp-content/plugins/photo-directory/inc/photo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,16 @@ public static function get_exif( $post_id, $exif_keys = [] ) {
break;
case 'shutter_speed':
$label = 'Shutter Speed';
$value = '1/' . (int)( 1.0 / (float) $value );
// The value is the exposure time in seconds; skip anything that is not a positive number.
if ( ! is_numeric( $value ) || 0 >= $value ) {
continue 2;
}
// As cameras do, show exposures up to 1/4 second (with a margin for float error) as a rounded fraction and longer ones in seconds.
if ( $value < 0.25001 ) {
$value = '1/' . (int) round( 1 / $value );
} else {
$value = rtrim( rtrim( number_format( (float) $value, 1, '.', '' ), '0' ), '.' ) . 's';
}
break;
}

Comment thread
coderabbitai[bot] marked this conversation as resolved.
Expand Down
Loading