Repository navigation
Conversation
The rejected photos list used `g:s` (seconds) and the publish box used `H:m` (month) where the minutes belong. Both now use `i`.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Correct rejection date format tokens wordpress.org/public_html/wp-content/plugins/photo-directory/inc/rejection.php |
The default format changes from g:s a to g:i a. The display format changes from H:m:s to H:i:s. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Suggested reviewers: coffee2code, obenland
Merge Risk: 
f1319
-
The PR corrects the rejection-time displays without introducing an identified merge-blocking risk.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: correcting minute formatting in rejection times. Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
The time a photo was rejected shows the wrong minutes in both places the admin shows it.
get_rejection_date(),Y/m/d g:s a.sis seconds, so a photo rejected at 09:07:45 shows2026/10/24 9:45 am.Y-m-d H:m:s.mis the month, so the same photo shows2026-10-24 09:10:45.Both formats came in with the plugin's first public commit, r11679.
This changes
stoiin the first format andmtoiin the second, and updates the docblock default. Each place keeps its own format otherwise.Testing
In a local WordPress trunk site, I loaded the plugin's
registrations.phpandrejection.php, created a rejected photo, set itsrejected_onmeta, and captured the output ofcustom_rejection_columns()andshow_rejection_info():rejected_on2026-10-24 09:07:452026/10/24 9:45 am2026/10/24 9:07 am2026-10-24 09:10:452026-10-24 09:07:452026-03-05 21:04:582026/03/05 9:58 pm2026/03/05 9:04 pm2026-03-05 21:03:582026-03-05 21:04:58log_rejection()storescurrent_time( 'mysql' ), andmysql2date()reads and formats it in the same site timezone, so the time shown is the stored local time.log_rejection()call, both places show the stored time.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code and Codex
Used for: Finding the bug while reading the plugin, the local tests, and the wording of this description. I reviewed the change and the results, and I take responsibility for the contribution.
Summary by CodeRabbit