Repository navigation
Conversation
Core's `expectDeprecated()` falls back to `PHPUnit\Util\Test::parseTestMethodAnnotations()` when `getAnnotations()` is missing, and PHPUnit 10 removed it, so the test errored before running. Provide an empty `getAnnotations()`, as the Translation Events tests do. Follow-up to [8948820]. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 46 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The WP: Support Forums unit test job fails on
trunk(scheduled run 39714665029) and on every PR that touches the plugin:Cause
Review_Edit_Lock_Test, added in 8948820, extends Core'sWP_UnitTestCase. Core'sexpectDeprecated()reads annotations withgetAnnotations()when that method exists and otherwise falls back toPHPUnit\Util\Test::parseTestMethodAnnotations(). PHPUnit 10 removed the fallback, and the test environments install PHPUnit 11.Fix
Give the test an empty
getAnnotations(), matchingwporg-gp-translation-events/tests/class-base-test.php. The test uses no@expectedDeprecated/@expectedIncorrectUsageannotations, so an empty set is equivalent.Testing
php -land PHPCS pass.wp-env startfor the test environment didn't finish locally.🤖 Generated with Claude Code