Skip to content

Fix typos #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix typos #678

merged 1 commit into from
Oct 12, 2023

Conversation

@szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Oct 11, 2023 •
edited
Loading

What is this PR doing?

Fixes misspellings.

What problem is it solving?

Typos.

Could we have a list of generated code/data in .gitattributes?

/package-lock.json linguist-generated

Something like this.

package-lock.json
packages/docs/site/static/diagrams.excalidraw
packages/php-wasm/compile/build-assets/zlib/
packages/php-wasm/node/public/
packages/php-wasm/node/src/test/test-data/
packages/php-wasm/web/public/php_*
packages/playground/remote/public/wp-*
packages/playground/remote/src/wordpress/

@szepeviktor szepeviktor requested a review from a team as a code owner October 11, 2023 17:07
ajitbohra
ajitbohra approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@ajitbohra ajitbohra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Could we have a list of generated code/data in .gitattributes?

Sounds good +1

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Oct 11, 2023

Could we have a list of generated code/data in .gitattributes?

Sounds good +1

The list above is my guess.
Please have someone make up that list who knows the internals of this repo.

@adamziel adamziel added [Type] Documentation Improvements or additions to documentation [Type] Enhancement New feature or request labels Oct 12, 2023
@adamziel
Copy link
Collaborator

adamziel commented Oct 12, 2023

Thank you @szepeviktor!

Could we have a list of generated code/data in .gitattributes?

Would you please open an issue to track that?

@adamziel adamziel merged commit 15ce57b into WordPress:trunk Oct 12, 2023
@szepeviktor szepeviktor deleted the fix-typos branch October 12, 2023 07:14
@szepeviktor szepeviktor mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamziel adamziel adamziel approved these changes

+1 more reviewer

@ajitbohra ajitbohra ajitbohra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Documentation Improvements or additions to documentation [Type] Enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szepeviktor @adamziel @ajitbohra