Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users in #4419 recovered from startup failures by updating the service worker in DevTools and reloading. The “Try again” buttons on the remote hiccup screen and the website's application-load fallback now request that update, wait for the replacement worker to activate and control the page, and reload. A shared Vite plugin inlines the recovery function into both HTML pages so it remains available when application assets fail to load.
Recovery is user initiated and bounded to 15 seconds. Failed updates display the error and leave the button available for another attempt; successful recovery preserves the URL and browser storage. If there is no existing registration, the button reloads normally. This improves recovery and does not establish or fix the cause of the reported HTTP 403 responses.
Validation:
npm exec nx -- test playground-website --testFile=service-worker-recovery.spec.ts— six passing tests, including activation/control ordering, update rejection followed by retry, and timeout handling.npm exec nx -- run-many -t typecheck -p playground-website playground-remotenpm exec nx -- run-many -t lint -p playground-website playground-remote