Skip to content

[Web] Fix bugs with running personal WP dev server#3391

Merged
brandonpayton merged 3 commits intotrunkfrom
stop-offline-caching-for-personal-wp
Mar 13, 2026
Merged

[Web] Fix bugs with running personal WP dev server#3391
brandonpayton merged 3 commits intotrunkfrom
stop-offline-caching-for-personal-wp

Conversation

@brandonpayton
Copy link
Copy Markdown
Member

@brandonpayton brandonpayton commented Mar 13, 2026

Motivation for the change, related issues

There are some places in Playground that do not properly acknowledge the personal-wp dev server origin of http://127.0.0.1:5401:

  • Not excluded from offline asset caching
  • Not allowed by default by the CORS proxy script

In addition, the local CORS proxy was not working for @zaerl and I, and @zaerl noticed that the CORS proxy output was being corrupted by an inline warning due to curl_close() being deprecated in PHP 8.5+.

Implementation details

  • Add http://127.0.0.1:5401 to the relevant allow and exclude lists.
  • Set display_errors to zero in cors-proxy.php
  • Only call curl_close() when the PHP version is below 8.5

Testing Instructions (or ideally a Blueprint)

  • CI
  • Run npx nx dev playground-personal-wp on a clean browser env and confirm it loads the Your WordPress welcome page.

@brandonpayton brandonpayton requested review from a team and bgrgicak March 13, 2026 20:41
Copilot AI review requested due to automatic review settings March 13, 2026 20:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the offline asset caching ignore list so the my.wordpress.net dev server (port 5401) isn’t treated as cacheable/offline content, preventing asset load failures during local development.

Changes:

  • Added 127.0.0.1:5401 and localhost:5401 to the shouldCacheUrl ignore list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zaerl zaerl self-requested a review March 13, 2026 20:54
@brandonpayton brandonpayton changed the title [Web] Stop caching offline assets for my.wordpress.net dev [Web] Fix bugs with running personal WP dev server Mar 13, 2026
Copy link
Copy Markdown
Collaborator

@zaerl zaerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@brandonpayton brandonpayton merged commit fd2283d into trunk Mar 13, 2026
43 checks passed
@brandonpayton brandonpayton deleted the stop-offline-caching-for-personal-wp branch March 13, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Personal Playground [Type] Bug An existing feature does not function as intended [Type] Developer Experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants