Conversation
There was a problem hiding this comment.
Pull request overview
Re-enables WebKit (Safari) in Playwright projects and CI sharding, and updates the e2e suite to skip clipboard-permissions tests on WebKit due to Playwright/browser limitations.
Changes:
- Re-enabled the
webkitPlaywright project using the Desktop Safari device profile. - Added WebKit to the CI matrix with 3 shards for parallel execution.
- Skipped the clipboard-link test on WebKit (and updated the skip reason).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/playground/website/playwright/playwright.config.ts | Re-enables the webkit Playwright project so it runs alongside Chromium/Firefox. |
| packages/playground/website/playwright/e2e/website-ui.spec.ts | Extends clipboard-related test skipping to include WebKit and updates the reason string. |
| .github/workflows/ci.yml | Adds WebKit to the CI browser/shard matrix to run in parallel like other browsers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // }, | ||
| { | ||
| name: 'webkit', | ||
| use: { ...devices['Desktop Safari'] }, |
There was a problem hiding this comment.
This PR re-enables WebKit after it was previously disabled due to random CI failures (per PR description). To reduce the risk of re-introducing flaky CI, consider adding WebKit-specific stabilization in the config (e.g., higher retries only for the WebKit project, enabling trace/video on first retry, or a slightly higher per-test timeout for WebKit). This keeps CI noise down while still getting WebKit coverage.
| use: { ...devices['Desktop Safari'] }, | |
| retries: 5, | |
| use: { | |
| ...devices['Desktop Safari'], | |
| trace: 'on-first-retry', | |
| video: 'on-first-retry', | |
| actionTimeout: 180000, | |
| navigationTimeout: 180000, | |
| }, |
There was a problem hiding this comment.
I don't want to add this right now so as to allow the flakiness to surface itself, if it still exists.
ashfame
force-pushed
the
reenable_webkit_e2e
branch
from
b62c356 to
440103f
Compare
|
I updated this PR to have latest from trunk so the tests run again. If they continue to be stable, we can just merge this and adjust if we see stability issues in the future. |
|
AFAIK, these haven't crashed as part of this PR. @WordPress/playground-maintainers, let's re-enable the WebKit E2E tests and revisit if reliability issues reappear. |
This PR re-enables WebKit browser testing in both the Playwright configuration and the CI workflow, after previously being disabled due to instability. It also updates the test suite to skip clipboard-related tests on WebKit, reflecting current browser limitations.
Rebased over trunk for another CI run: Passes 🟢