Repository navigation
Revert "[PHP] Recompile PHP.wasm Node JSPI with MAIN_MODULE set to 2" - #3330
Merged
Merged
Conversation
brandonpayton
changed the title
Member
Author
|
I may merge this yet this evening but am trying one last thing to fix the errors in #3329: Rebuild the intl extension for php-wasm/web. |
Member
Author
|
@mho22 That didn't work, so I'll go ahead revert. That way, we can make other php-wasm updates while adjusting the MAIN_MODULE=2 changes. |
brandonpayton
pushed a commit
that referenced
this pull request
Mar 3, 2026
## Motivation for the change, related issues Based on the previous pull request : #3244 And reverting it here : #3330 And because I should have been more careful : Now this pull request sets `MAIN_MODULE=2` to PHP.wasm Web JSPI and PHP.wasm Node JSPI. ## Implementation details Anything related to : #3244 `+` - Added a `__c_longjmp` condition since it is only needed for Xdebug [ PHP.wasm Node JSPI ] - Added a `_wasm_recv` condition since it is only needed for Memcached [ PHP.wasm Node JSPI ] - Modified extensions location in PHP.wasm Web - Recompiled PHP.wasm Node JSPI - Rebuilt Intl for Web JSPI [ since it needs `/root/lib/libicuio.a` ] - Recompiled PHP.wasm Web JSPI ## Testing Instructions (or ideally a Blueprint) CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
This reverts commit 17ece53. (#3244)
There are php-wasm build issues after this change. I initially tried to fix them with #3329, but some tests are still failing after successfully rebuilding everything. Let's revert to get the builds passing again.
cc @mho22
Implementation details
Revert the MAIN_MODULE=2 change.
Testing Instructions (or ideally a Blueprint)