Support short arguments for Playground CLI#3203
Open
jonathanbossenger wants to merge 5 commits intoWordPress:trunkfrom
Open
Support short arguments for Playground CLI#3203jonathanbossenger wants to merge 5 commits intoWordPress:trunkfrom
jonathanbossenger wants to merge 5 commits intoWordPress:trunkfrom
Conversation
Collaborator
|
Good idea @jonathanbossenger! It seems in CI like there are some troubles on Windows - can we improve that? |
Collaborator
Author
|
Thanks @adamziel, I missed that, probably something wrong with my tests. Will look into it and get the PR updated. |
Collaborator
Author
|
@adamziel I've fixed the errors with the tests. |
| // wp-playground start --help | ||
| // wp-playground build-snapshot --help | ||
|
|
||
| expect(true).toBe(true); |
Member
There was a problem hiding this comment.
This is a tautology, and the unit test doesn't do anything. Is this worth fixing, or should it be removed?
Initially, I thought maybe it should be removed, but I don't think there is much downside to have a test declare what short arguments are supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
This is a developer experience QOL enhancement, which adds aliases (aka short arguments) to the majority of the most used CLI arguments