Repository navigation
Add SQLITE_ENABLE_COLUMN_METADATA and update SQLite - #2948
Merged
Merged
Conversation
adamziel
approved these changes
Nov 26, 2025
JanJakes
changed the title
SQLITE_ENABLE_COLUMN_METADATA and update SQLiteSQLITE_ENABLE_COLUMN_METADATA and update SQLite
JanJakes
marked this pull request as ready for review
November 27, 2025 09:33
Member
Author
|
I added tests, they're passing, so merging this now. |
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Our SQLite builds don't set the
SQLITE_ENABLE_COLUMN_METADATAflag, which results in some metadata missing whenPDOStatement::getColumnMetais used. This results in issues like missing row editing controls in phpMyAdmin and possibly other problems.This flag seems to be set in most libsqlite3 builds: https://www.rogerbinns.com/blog/sqlite-configuration.html
Therefore, I think it's safe to add it and, from the SQLite side, assume that it's always used.
Implementation details
I added the flag, updated SQLite, rebuilt it, and rebuilt all PHP builds.
Testing Instructions (or ideally a Blueprint)
I added tests for the
SQLITE_ENABLE_COLUMN_METADATAand they need to pass.