Repository navigation
Conversation
adamziel
added
[Type] Enhancement
adamziel
marked this pull request as ready for review
November 27, 2025 23:05
Collaborator
Author
|
There's some superficial differences in whitespaces, I'll adjust them in a follow-up. |
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Upgrades GD version to 2.3.3. The EWWW Image Optimizer relies on GD library features shipped with a more recent GD version than the one bundled with PHP. See nosilver4u/ewww-image-optimizer#377
Implementation details
PHP comes with a bundled GD version 2.1.0. Upgrading to 2.3.3 involves:
packages/php-wasm/compile/libgd)--with-external-gd/root/php-src/ext/gd/gd.c:3536:8: error: use of undeclared identifier 'GD_FLIP_VERTICAL'.Testing Instructions (or ideally a Blueprint)
CI – we have tests covering
gdacross all PHP versions.