Repository navigation
[PHP Worker] listen to all PHP instances events via worker.addEventListener() - #2673
Merged
Merged
Conversation
…stener() Before this PR, worker.addEventListener() only listens to the events emitted by the primary PHP instance. After this PR, it listens to events emitted by all the PHP instances created by a given worker. ## Implementation details Instead of passing through the `worker.addEventListener()` call to the primary PHP instance, the PHPWorker class: * Registers a wildcard event listener for all PHP events. * Maintains its own list of event listeners. Whenever any PHP instance emits an event that has worker-wide listeners registered, the worker class notifies them. This PR refactors all the worker implementations: web and node, v1 and v2. ## Testing instructions CI (TODO: Add test coverage)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, worker.addEventListener() only listens to the events emitted by the primary PHP instance. After this PR, it listens to events emitted by all the PHP instances created by a given worker.
Implementation details
Instead of passing through the
worker.addEventListener()call to the primary PHP instance, the PHPWorker class:Whenever any PHP instance emits an event that has worker-wide listeners registered, the worker class notifies them.
This PR refactors all the worker implementations: web and node, v1 and v2.
Testing instructions
CI (TODO: Add test coverage)