Fix error from adding blank target to external links#2575
Merged
adamziel merged 4 commits intoWordPress:trunkfrom Aug 30, 2025
Merged
Fix error from adding blank target to external links#2575adamziel merged 4 commits intoWordPress:trunkfrom
adamziel merged 4 commits intoWordPress:trunkfrom
Conversation
Collaborator
|
Turns out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
We use playground as a preview tool inside an app that generates WordPress blocks via AI assistant. We encounter
JavaScript Error: TypeError: e.target.closest is not a functioncoming from Playground and it encumbers our assisted error recovery because it comes from outside of the generated code.Implementation details
We don't attempt to update the link if the element surprisingly doesn't have a closest method (which is why we also log the element to see why this happens)
Testing Instructions (or ideally a Blueprint)
Hard to figure out, sometimes it occurs.