Repository navigation
Fix customize bundle instructions in "Host Own Playground" docs - #2510
Conversation
brandonpayton
added
[Type] Documentation
|
If the CI tests pass, I'll go ahead and merge, and we can clean up in a follow-up PR if desired. |
|
There are some Cypress E2E failures:
The same tests failed twice in a row, but I'm not sure why. At least for the failing admin login test, the screenshot shows the test runner logged into the site editor which is part of the admin. I'll try a third run and then dig further if the same failures continue. |
|
I created a test PR with no meaningful commits apart from trunk, and it has the same E2E test failures: So the failures appear to have nothing to do with this PR. That said, I think I see the reason for the E2E failures and just pushed 6884af8 to hopefully fix them. |
|
It turned out there really was a missing asset from the docs build for pt-br. I'm not sure how previous CI builds didn't catch this. But we can fix it here. |
|
This was an unexpected adventure with three different unrelated failures during CI. But those are now fixed as part of this PR. :) Let's merge! |
|
@brandonpayton, to avoid this issue with assets, I will move the images to a global folder. It only makes sense to duplicate them when the image contains localized content. |
|
I have created the issue: #2516 |
Thanks, @fellyph, that sounds good. If we are going to fix that, I think other locales may also have some English duplicates. Last night when I was trying to fix the build issue, I saw that "ja" had an English instance of that same image (or thought it did when viewing through VSCode). |
Motivation for the change, related issues
Our build instructions for customized WP bundles are both incorrect and incomplete. The purpose of this PR is to fix that and make the experience clearer and less error prone.
cc @n8finch @fellyph
Implementation details
This PR:
npm run rebuild:wordpress-builds.emptyOutDir: truein the Playground remote package Vite config.Due to CI bugs experienced with this branch, this PR also fixes:
Testing Instructions (or ideally a Blueprint)
npm run rebuild:wordpress-buildsand confirm that it rebuilt all supported WP versionsNote: As an additional test, I modified one of the new WP zip files, ran
npm run build:website, and confirmed the zip file changes were included in the corresponding zip underdist/packages/playground/wasm-wordpress-net/assets.