Skip to content

Commit 1add040

Browse files
committed
Rephrase PROXYFS comment to reflect uncertain root cause
The multi-instance corruption on legacy PHP may be a PROXYFS bug rather than a PHP parser issue — these sites worked on real servers originally. Add a TODO to investigate the actual root cause.
1 parent cf77a58 commit 1add040

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

‎packages/playground/remote/src/lib/playground-worker-endpoint.ts‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -192,12 +192,15 @@ export abstract class PlaygroundWorkerEndpoint extends PHPWorker {
192192
}
193193

194194
const parsedSiteUrl = new URL(siteUrl);
195-
// Legacy PHP has a parser state bug that corrupts large include
196-
// chains when a secondary PHP instance accesses the WordPress
197-
// source via PROXYFS. Force single-instance mode so all requests
198-
// run on the primary and the PROXYFS bug never surfaces. The
199-
// SinglePHPInstanceManager serializes concurrent requests on the
200-
// primary via a 1-concurrency semaphore.
195+
// Multi-instance mode breaks on legacy PHP: large include chains
196+
// corrupt when a secondary instance reads WordPress sources
197+
// through PROXYFS. The root cause is unclear — it may be a
198+
// PROXYFS bug rather than a PHP parser issue (these sites worked
199+
// on real servers at the time). For now, force single-instance
200+
// mode so every request runs on the primary PHP instance. The
201+
// SinglePHPInstanceManager serializes concurrent requests via a
202+
// 1-concurrency semaphore.
203+
// TODO: Investigate the actual root cause in PROXYFS.
201204
const isLegacyPhp = isLegacyPHPVersion(phpVersion);
202205
const requestHandler = await bootRequestHandler({
203206
siteUrl,

0 commit comments

Comments
 (0)