Block Bindings: Communicate supported block attributes from server side #9992
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
ockham
changed the title
get_block_bindings_supported_attributes() fn
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
ockham
force-pushed
the
add/get-block-bindings-supported-attributes
branch
from
7f40f9b to
af99215
Compare
3 participants
Instead of keeping a separate list of block attributes that are supported by Block Bindings, communicate that list from the server -- including block attributes that were added there via the
block_bindings_supported_attributesfilter.GB counterpart: WordPress/gutenberg#71820
Testing Instructions
Navigate to the editor. Inspect the page source, and verify that it contains a JS variable called
blockBindingsSupportedAttributes, which is set to an object with block type names as keys, and lists of block attributes as values. Note that the list should include any block attributes added via theblock_bindings_supported_attributesfilter.{ "blockBindingsSupportedAttributes":{"core/button":["url","text","linkTarget","rel"],"core/heading":["content"],"core/image":["id","url","title","alt"],"core/post-date":["datetime"],"core/paragraph":["content"]} }Trac ticket: https://core.trac.wordpress.org/ticket/64030
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.