Fix: Update get_delete_post_link() to support post types with multiple _edit_link placeholders#9952
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
Trac Ticket: Core-61716
Problem
get_delete_post_link()assumes _edit_link contains only a single placeholder (e.g. post.php?post=%d).Gutenberg post types such as wp_template and wp_template_part define _edit_link with multiple placeholders (e.g. site-editor.php?postType=%s&postId=%s&canvas=edit).
This mismatch causes
sprintf()to throw an ArgumentCountError when generating delete links.Solution
Update
get_delete_post_link()to dynamically count placeholders in _edit_link and adjust the arguments passed tovsprintf().This ensures compatibility with both classic and Gutenberg CPTs, prevents fatal errors, and future-proofs the function against additional placeholders.