Administration: Replace incorrect cite elements with span for author names#9935
Draft
himanshupathak95 wants to merge 5 commits intoWordPress:trunkfrom
Draft
Administration: Replace incorrect cite elements with span for author names#9935himanshupathak95 wants to merge 5 commits intoWordPress:trunkfrom
cite elements with span for author names#9935himanshupathak95 wants to merge 5 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
himanshupathak95
force-pushed
the
fix/17520
branch
from
15bee14 to
e9321ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/17520
This PR fixes incorrect usage of
<cite>elements for author names throughout the WP admin to comply with HTML5 semantic standards.The HTML5 specification states that
<cite>should only be used for titles of works (books, movies, songs, etc.), not for author names. This change replaces all instances where<cite>incorrectly wraps author names with semantically appropriate<span>elements.<cite>with<span class="plugin-author">for plugin authors<cite>with<span class="plugin-author">in plugin descriptions<cite class="comment-author">with<span class="comment-author">