Skip to content

Switch is_user_member_of_blog to only fetch a specific user meta key for capability rather than all meta keys for the user #9920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rinatkhaziev wants to merge 4 commits into from
Closed

Switch is_user_member_of_blog to only fetch a specific user meta key for capability rather than all meta keys for the user #9920

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dd7185
Switch is_user_member_of_blog to only fetch a specific user meta key …
rinatkhaziev Sep 16, 2025
5696ee5
Simplify the logic per suggestion from @jonnynews
rinatkhaziev Oct 20, 2025
36ff6f1
Simplify the logic per suggestion from @jonnynews
rinatkhaziev Oct 20, 2025
9143354
Remove double empty line per phpcs
rinatkhaziev Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions src/wp-includes/user.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,24 +1179,14 @@ function is_user_member_of_blog( $user_id = 0, $blog_id = 0 ) {
return false;
}

$keys = get_user_meta( $user_id );
if ( empty( $keys ) ) {
return false;
}

// No underscore before capabilities in $base_capabilities_key.
$base_capabilities_key = $wpdb->base_prefix . 'capabilities';
$site_capabilities_key = $wpdb->base_prefix . $blog_id . '_capabilities';

if ( isset( $keys[ $base_capabilities_key ] ) && 1 === $blog_id ) {
return true;
}

if ( isset( $keys[ $site_capabilities_key ] ) ) {
return true;
if ( 1 === $blog_id ) {
$capabilities_key = $wpdb->base_prefix . 'capabilities';
} else {
$capabilities_key = $wpdb->base_prefix . $blog_id . '_capabilities';
}
$has_cap = get_user_meta( $user_id, $capabilities_key, true );

return false;
return is_array( $has_cap );
}

/**
Expand Down