Cron: Fix timestamp 0 handling across cron functions#9914
Cron: Fix timestamp 0 handling across cron functions#9914R1shabh-Gupta wants to merge 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| function wp_unschedule_event( $timestamp, $hook, $args = array(), $wp_error = false ) { | ||
| // Make sure timestamp is a positive integer. | ||
| if ( ! is_numeric( $timestamp ) || $timestamp <= 0 ) { | ||
| if ( ! is_numeric( $timestamp ) || $timestamp < 0 ) { |
There was a problem hiding this comment.
Shouldn't be the same code block applied on wp_schedule_single_event() as well?
There was a problem hiding this comment.
wp_schedule_event + wp_reschedule_event too since all of them uses same validation
There was a problem hiding this comment.
Thank you for catching this. I’ve updated wp_schedule_single_event accordingly, and also applied the same changes to wp_schedule_event and wp_reschedule_event as they contained similar code.
| function wp_unschedule_event( $timestamp, $hook, $args = array(), $wp_error = false ) { | ||
| // Make sure timestamp is a positive integer. | ||
| if ( ! is_numeric( $timestamp ) || $timestamp <= 0 ) { | ||
| if ( ! is_numeric( $timestamp ) || $timestamp < 0 ) { |
There was a problem hiding this comment.
wp_schedule_event + wp_reschedule_event too since all of them uses same validation
|
|
||
| // Manually add an event at timestamp 0 to the cron array. | ||
| $crons = _get_cron_array(); | ||
| if ( ! $crons ) { |
3 participants
Trac ticket: https://core.trac.wordpress.org/ticket/63987