Fix WP_Object_Cache deep copy for objects nested in arrays#9750
Open
himanshupathak95 wants to merge 6 commits intoWordPress:trunkfrom
Open
Fix WP_Object_Cache deep copy for objects nested in arrays#9750himanshupathak95 wants to merge 6 commits intoWordPress:trunkfrom
WP_Object_Cache deep copy for objects nested in arrays#9750himanshupathak95 wants to merge 6 commits intoWordPress:trunkfrom
Conversation
himanshupathak95
force-pushed
the
fix/30430
branch
from
43fd245 to
770030d
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/30430
Objects stored in arrays within WP_Object_Cache were sharing references with the original data, causing unexpected mutations when either the original or cached data was modified.
This change adds deep copying functionality to properly clone objects nested within arrays at any level, ensuring cached data remains isolated from the original data structures.
Changes:
Fixes reference sharing issue while maintaining performance for primitive arrays.
Follows the implementation of the patch - https://core.trac.wordpress.org/attachment/ticket/30430/wp-deep-copy-withclass2.diff