Add action when term count is updated#9698
Add action when term count is updated#9698leonidasmi wants to merge 5 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
A couple of notes inline.
src/wp-includes/taxonomy.php
Outdated
| * @param string $taxonomy_name Taxonomy slug. | ||
| * @param int $count Term count. | ||
| */ | ||
| do_action( 'update_term_count', $term, $taxonomy->name, $count ); |
There was a problem hiding this comment.
Could be worth including $check_attachments too.
There was a problem hiding this comment.
My thoughts on this feedback:
- No, it is not necessary to include
$check_attachmentsin the action. - If a developer needs to know if attachments were included, they can check the taxonomy object.
There was a problem hiding this comment.
I'd rather keep the action's signature the same for post terms and generic terms, for uniformity purposes.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
3 participants
Trac ticket: https://core.trac.wordpress.org/ticket/63904
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.