refactor: use PHPMailer's parseAddresses#9697
Draft
JDeepD wants to merge 5 commits intoWordPress:trunkfrom
Draft
refactor: use PHPMailer's parseAddresses#9697JDeepD wants to merge 5 commits intoWordPress:trunkfrom
JDeepD wants to merge 5 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
JDeepD
force-pushed
the
refactor/use-phpmailer-parseaddresses
branch
3 times, most recently
from
451d6c4 to
73f43b9
Compare
JDeepD
force-pushed
the
refactor/use-phpmailer-parseaddresses
branch
3 times, most recently
from
b891f55 to
8fbc583
Compare
Current implementation uses naive approach of splitting email address headers at ,. This makes perfectly valid headers like "Jane, Doe" <jane@example.com> break. We should use PHPMailer's parseAddresses() function which uses IMAP extension (if available) which addresses this issue instead of the current implementation. Additionally, add support for encoded addresses in headers with the help of parseAddresses(). Trac ticket: #62940
JDeepD
force-pushed
the
refactor/use-phpmailer-parseaddresses
branch
from
8fbc583 to
697bb53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation uses naive approach of
splitting email address headers at
,. This makes perfectly valid headers like"Jane, Doe" <jane@example.com>break. But this is a perfectly valid RFC-5322 email address header.We should use PHPMailer's parseAddresses() function which uses IMAP extension (if available) which addresses this issue instead of the current implementation.
Trac ticket: #62940
TODO: