Options API: Fix delete_option() cache cleanup for null values#9643
Options API: Fix delete_option() cache cleanup for null values#9643himanshupathak95 wants to merge 2 commits intoWordPress:trunkfrom
delete_option() cache cleanup for null values#9643Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: https://core.trac.wordpress.org/ticket/28701
This PR fixes a long-standing bug where
delete_option()fails to remove options with null values from the alloptions cache.When an autoloaded option contains
null,delete_option()usesisset($alloptions[$option])to check cache presence. Sinceisset(null) === false, options with null values remain in cache after deletion, causingget_option()to return stale cached values instead of defaults.This PR -
isset()witharray_key_exists()for proper null detectionwp_cache_delete()to ensure complete cache cleanup