General: Add input validation to get_calendar() for invalid week and month parameters#9575
General: Add input validation to get_calendar() for invalid week and month parameters#9575himanshupathak95 wants to merge 5 commits intoWordPress:trunkfrom
get_calendar() for invalid week and month parameters#9575Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
…d month parameters
2564565 to
3853507
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: https://core.trac.wordpress.org/ticket/41011
This PR addresses security and stability issues in the
get_calendar()function by adding proper input validation for week and month parameters.This PR validates -
$wparameter is between 1-53, falls back to normal calendar for invalid values$monthnumis between 1-12, falls back to the current month for invalid values$mparametersubstr()error when$mis null but$wis providedProps @pbearne for the original patch and tests.
Refreshed Implementation of PR - #8064