fix: Reply-To header in comment reply emails#9543
fix: Reply-To header in comment reply emails#9543JDeepD wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The Reply-To header in comment reply notification emails was being manually formatted with quotes, similar to the From header. However, PHPMailer treats these headers differently: - From headers are set via `setFrom()`, which applies proper quoting and encoding internally. - Reply-To headers in core were added as custom headers via `addCustomHeader()`, which passes the value through `encodeHeader()` and escapes quotes a second time. This mismatch caused author names with quotes to be encoded as: Reply-To: \"Author\" <author@example.com> This commit fixes this issue. See Trac #49661
JDeepD
force-pushed
the
fix/comment-reply-to-headers
branch
from
1054446 to
5337966
Compare
1 participant
Trac ticket: #49661
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.