Add tests for custom block layout classname generation#9541
Add tests for custom block layout classname generation#9541R1shabh-Gupta wants to merge 4 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
LGTM! We could remove the regression test as I mentioned below, but that's not a dealbreaker.
| * | ||
| * @dataProvider data_layout_classname_with_core_blocks | ||
| */ | ||
| public function test_layout_classname_works_for_core_blocks( $block_name, $layout_type, $expected_class, $should_not_contain ) { |
There was a problem hiding this comment.
We don't really need this test because we already test classnames output for core blocks here.
|
Not sure why the tests are failing on CI; they pass for me locally. |
|
@tellthemachines, I merged the latest trunk branch into this branch. Hopefully, this will resolve the test failure. |
|
@tellthemachines, it seems the CI failure has been fixed. If you have the bandwidth, please feel free to commit! |
|
Done, thanks for the updates @t-hamano ! |
3 participants
Trac ticket: https://core.trac.wordpress.org/ticket/63839