feat: add js_trim() and mb_trim() compat#9519
feat: add js_trim() and mb_trim() compat#9519USERSATOSHI wants to merge 7 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
2 participants
PHP’s trim() function, by default, only strips a limited set of ASCII whitespace characters, and mb_trim(), introduced in PHP 8.4, does not behave identically to JavaScript’s String.prototype.trim().
This PR implements
js_trim(), a PHP function that replicates JavaScript’sString.prototype.trim()behavior.It works by defining a set of
$js_trimmablescharacters, which are passed tomb_trim()withUTF-8encoding.In addition, this PR adds a polyfill for
mb_trim()incompat.phpto support PHP versions below 8.4 with unit tests for bothjs_trim()andmb_trim()Trac ticket: https://core.trac.wordpress.org/ticket/63804
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.