Skip to content

Fixes stale cron list upon finishing a long-running job #9496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slavicd wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Fixes stale cron list upon finishing a long-running job #9496

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b03c6c1
Fixes stale cron list upon finishing a long-running job
slavicd Aug 15, 2025
d3b6a08
coding style fix
slavicd Aug 15, 2025
6fd7a8e
Merge branch 'WordPress:trunk' into trunk
slavicd Sep 9, 2025
2e30f2e
The previous fix is insufficient, as the corn gets overridden by `wp_…
slavicd Sep 9, 2025
bc6f52f
Merge remote-tracking branch 'origin/trunk' into trunk
slavicd Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/wp-includes/cron.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ function wp_schedule_single_event( $timestamp, $hook, $args = array(), $wp_error
* current time) all events scheduled within the next ten minutes
* are considered duplicates.
*/
$crons = _get_cron_array();
$crons = _get_cron_array( true );

$key = md5( serialize( $event->args ) );
$duplicate = false;
Expand Down Expand Up @@ -300,7 +300,7 @@ function wp_schedule_event( $timestamp, $recurrence, $hook, $args = array(), $wp

$key = md5( serialize( $event->args ) );

$crons = _get_cron_array();
$crons = _get_cron_array( true );

$crons[ $event->timestamp ][ $event->hook ][ $key ] = array(
'schedule' => $event->schedule,
Expand Down Expand Up @@ -507,7 +507,7 @@ function wp_unschedule_event( $timestamp, $hook, $args = array(), $wp_error = fa
return $pre;
}

$crons = _get_cron_array();
$crons = _get_cron_array( true );
$key = md5( serialize( $args ) );

unset( $crons[ $timestamp ][ $hook ][ $key ] );
Expand Down Expand Up @@ -1223,9 +1223,14 @@ function wp_get_ready_cron_jobs() {
* @since 6.1.0 Return type modified to consistently return an array.
* @access private
*
* @param bool $fresh whether a non-cached version is required
* @return array[] Array of cron events.
*/
function _get_cron_array() {
function _get_cron_array( $fresh = false ) {
if ( $fresh ) {
wp_cache_delete( 'alloptions', 'options' ); // there doesn't seem to be a more surgical way
}

$cron = get_option( 'cron' );
if ( ! is_array( $cron ) ) {
return array();
Expand Down
Loading