HTML API: Make WP_HTML_Processor::serialize_token() public.
#9456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
sirreal
approved these changes
Aug 12, 2025
Trac ticket: Core-63823 Follows WordPress#7331 The `serialize_token()` method was added in WordPress 6.7.0 as a protected member on the `WP_HTML_Processor` class. It wasn’t clear at the time of merging if it would be necessary to expose it as a public method. However, since that time a number of experiments have led to the conclusion that it would be very valuable to do so. This patch opens up the method for invocation from the outside, trivializing the generation of normative HTML subspans from a parent document. Follow-up to [[59076]](https://core.trac.wordpress.org/changeset/59076).
dmsnell
force-pushed
the
html-api/publicize-serialize-token
branch
from
1d94811 to
65c3a8e
Compare
pento
pushed a commit
that referenced
this pull request
Aug 13, 2025
The serialize_token() method was added in WordPress 6.7.0 as a protected member on the WP_HTML_Processor class. It wasn’t clear at the time of merging if it would be necessary to expose it as a public method. However, since that time a number of experiments have led to the conclusion that it would be very valuable to do so. This patch opens up the method for invocation from the outside, trivializing the generation of normative HTML subspans from a parent document. Developed in #9456 Discussed in https://core.trac.wordpress.org/ticket/63823 Follow-up to [59076]. Props dmsnell, jonsurrell. Fixes #38044. git-svn-id: https://develop.svn.wordpress.org/trunk@60633 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 13, 2025
The serialize_token() method was added in WordPress 6.7.0 as a protected member on the WP_HTML_Processor class. It wasn’t clear at the time of merging if it would be necessary to expose it as a public method. However, since that time a number of experiments have led to the conclusion that it would be very valuable to do so. This patch opens up the method for invocation from the outside, trivializing the generation of normative HTML subspans from a parent document. Developed in WordPress/wordpress-develop#9456 Discussed in https://core.trac.wordpress.org/ticket/63823 Follow-up to [59076]. Props dmsnell, jonsurrell. Fixes #38044. Built from https://develop.svn.wordpress.org/trunk@60633 git-svn-id: http://core.svn.wordpress.org/trunk@59969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Aug 13, 2025
The serialize_token() method was added in WordPress 6.7.0 as a protected member on the WP_HTML_Processor class. It wasn’t clear at the time of merging if it would be necessary to expose it as a public method. However, since that time a number of experiments have led to the conclusion that it would be very valuable to do so. This patch opens up the method for invocation from the outside, trivializing the generation of normative HTML subspans from a parent document. Developed in WordPress/wordpress-develop#9456 Discussed in https://core.trac.wordpress.org/ticket/63823 Follow-up to [59076]. Props dmsnell, jonsurrell. Fixes #38044. Built from https://develop.svn.wordpress.org/trunk@60633 git-svn-id: https://core.svn.wordpress.org/trunk@59969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Member
Author
|
Merged in 60633 |
jonnynews
pushed a commit
to spacedmonkey/wordpress-develop
that referenced
this pull request
Sep 24, 2025
The serialize_token() method was added in WordPress 6.7.0 as a protected member on the WP_HTML_Processor class. It wasn’t clear at the time of merging if it would be necessary to expose it as a public method. However, since that time a number of experiments have led to the conclusion that it would be very valuable to do so. This patch opens up the method for invocation from the outside, trivializing the generation of normative HTML subspans from a parent document. Developed in WordPress#9456 Discussed in https://core.trac.wordpress.org/ticket/63823 Follow-up to [59076]. Props dmsnell, jonsurrell. Fixes #38044. git-svn-id: https://develop.svn.wordpress.org/trunk@60633 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-63823
Follows #7331
The
serialize_token()method was added in WordPress 6.7.0 as a protected member on theWP_HTML_Processorclass. It wasn’t clear at the time of merging if it would be necessary to expose it as a public method. However, since that time a number of experiments have led to the conclusion that it would be very valuable to do so.This patch opens up the method for invocation from the outside, trivializing the generation of normative HTML subspans from a parent document.
Follow-up to [59076].