Media: Fix return type annotation for block_core_image_get_lightbox_settings()#9393
Closed
himanshupathak95 wants to merge 1 commit intoWordPress:trunkfrom
Closed
Media: Fix return type annotation for block_core_image_get_lightbox_settings()#9393himanshupathak95 wants to merge 1 commit intoWordPress:trunkfrom
block_core_image_get_lightbox_settings()#9393himanshupathak95 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Author
|
Closing this as completed via WordPress/gutenberg#71073 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/63790
This PR fixes the incorrect
@returnannotation inblock_core_image_get_lightbox_settings().The function can return
nullwhen lightbox settings are not found, but the DocBlock only documentsarrayas the return type. This PR updates the annotation to@return array|nullto accurately reflect the actual return behavior.